Re-worded navigating to extensions and UI install of plugin #8
Conversation
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
Hey, thanks for contributing! Your edits look good. I want you to be aware that we just merged in a LICENSE in #9 that will apply to your contribution if merged as well as an expanded README. See the section on the DCO sign-off. I'll assume that if you sign-off on your commit after this comment that you are also agreeing to the license terms. Let me know if you need assistance working with git.
|
I'm not mega familiar with git/github. Is it easier to close this PR? I can update my fork and make the same edits and then submit a new PR including DCO signoff in the commit? |
I couldn't really make sense of Settings -> Extensions as it doesn't correlate with what i'm seeing in OIE. Signed-off-by: edthri <riordaned@gmail.com> Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
force-pushed
the
edthri-patch-1
branch
from
80b01a3 to
f0f8788
Compare
@edthri I've updated the commit to add the signoff for you. If you just want to respond to this comment with your final approval that everything looks good and you agree to submit your changes under the new license terms I'll get it merged. |
|
I agree to submit my changes under the new license terms. Approval given. Thanks, |
tonygermano
temporarily deployed
to
github-pages
GitHub Actions
Inactive
2 participants
I couldn't really make sense of Settings -> Extensions as it doesn't correlate with what i'm seeing in OIE.